fix: gracefully close streamable HTTP sessions on shutdown#2716
Open
Hackerchen716 wants to merge 1 commit into
Open
fix: gracefully close streamable HTTP sessions on shutdown#2716Hackerchen716 wants to merge 1 commit into
Hackerchen716 wants to merge 1 commit into
Conversation
Hackerchen716
force-pushed
the
contrib/streamable-http-graceful-shutdown
branch
from
6841fdc to
08d234d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Fixes #2150.
StreamableHTTPSessionManager currently cancels its task group during lifespan shutdown before asking active stateful transports to close. StreamableHTTPServerTransport.terminate() also closes request/session streams, but it does not close active SSE stream writers.
Problem
When a server shuts down while clients have active Streamable HTTP SSE responses open, those response tasks can be cancelled before the response stream completes. That can surface as Uvicorn logging ASGI callable returned without completing response.
Solution
Validation
Ran:
Results:
Risk
Low. The behavior change is limited to shutdown/session termination paths. Normal request handling and stateless per-request cleanup are unchanged.
Breaking Changes
None.
Reviewer Notes
The main behavior to review is the ordering: active stateful transports are asked to terminate before the session manager cancels the task group, and terminate() now closes SSE stream writers in addition to request/session streams.